This line seems to break the association process in cases where the "Associate-with" tag is changed via parameter in CFN template.

aws-solutions / network-orchestration-for-aws-transit-gateway

The Network Orchestration for AWS Transit Gateway solution automates the process of setting up and managing transit networks in distributed AWS environments. It creates a web interface to help control, audit, and approve (transit) network changes.

https://aws.amazon.com/solutions/implementations/serverless-transit-network-orchestrator/

Apache License 2.0

113 stars 48 forks source link

This line seems to break the association process in cases where the "Associate-with" tag is changed via parameter in CFN template. #15

Closed nickda closed 2 years ago

nickda commented 4 years ago

https://github.com/awslabs/serverless-transit-network-orchestrator/blob/719d52c3627f5b4245339b65f84d18da166c5970/source/state_machine_handler.py#L1250

groverlalit commented 4 years ago

@nickda Thanks for bringing this to our attention. This should be _environ.get('ASSOCIATION_TAG')_ instead. We have created a backlog ticket to track this issue.

Dlozitskiy commented 3 years ago

Hello, any update on this?

It's a quite small change but prevents from using STNO v2 with custom attachment/propagation tags?

rakshb commented 2 years ago

We have fixed this issue in V3.0.0 which released this week.