search

aws-solutions / network-orchestration-for-aws-transit-gateway

The Network Orchestration for AWS Transit Gateway solution automates the process of setting up and managing transit networks in distributed AWS environments. It creates a web interface to help control, audit, and approve (transit) network changes.
https://aws.amazon.com/solutions/implementations/serverless-transit-network-orchestrator/
Apache License 2.0
110 stars 48 forks source link

Feature: Show Spoke Account Name in both approval email and the stno dashboard #59

Closed alexelshamouty closed 11 months ago

alexelshamouty commented 2 years ago

Description of changes:

When STNO receives a VPC/Subnet attachment and if approval is required. it dispaches an email to the network admin and it shows certain information in the web interface.

This information is missing the account name, and that makes it difficult for us to know where this request is coming from.

A few edits in the graphql schema, react and the stno state machine lambda should take care of that by calling Organisations().get_account_name on the passed spoke_account from the event.account.

If this information does not exist, stno will save None in the Dynamo DB table and it won't show anything in the Spoke Account Name in the web interface.

Kodus to @weargoggles for the idea

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

groverlalit commented 1 year ago

We have added this to our backlog and will review this in the next release.