aws-solutions / network-orchestration-for-aws-transit-gateway

The Network Orchestration for AWS Transit Gateway solution automates the process of setting up and managing transit networks in distributed AWS environments. It creates a web interface to help control, audit, and approve (transit) network changes.
https://aws.amazon.com/solutions/implementations/serverless-transit-network-orchestrator/
Apache License 2.0
110 stars 48 forks source link

When deleting VPC tags, the STNO does not change association/propagation #61

Closed costi1010 closed 1 year ago

costi1010 commented 2 years ago

When we remove the tags Associated-with and Propagated-to tags and values , STNO does not reflect the change. I would expect that at least the STNO removes the Association and propagation from the TGW RT

paul-e-allen commented 1 year ago

Are you sure about this issue?

I tested a simple deployment and found that when I deleted the Associated-with and Propagated-to tags from the VPC, STNO updated the TGW Route Table propagation. It left tags on the VPC:

You would need to remove the Attach-to-tgw tag from the subnet(s) in order for the TGW Attachment(s) to be removed. For me, STNO updated tagging on the subnet:

tbelmega commented 1 year ago

I can confirm what paul-e-allen already wrote, removing the Attach-to-tgw tag from the subnets and then removing Associate-with and Propagate-to works as expected.

I'm closing the issue. If you're still experiencing problems, please reopen with information about your STNO version number and steps that help us to reproduce the problem.

Best regards, Thiemo