search

aws-solutions / network-orchestration-for-aws-transit-gateway

The Network Orchestration for AWS Transit Gateway solution automates the process of setting up and managing transit networks in distributed AWS environments. It creates a web interface to help control, audit, and approve (transit) network changes.
https://aws.amazon.com/solutions/implementations/serverless-transit-network-orchestrator/
Apache License 2.0
110 stars 46 forks source link

Updated values for RFC1918 addressed to fix bug with splitting by "," #79

Closed martwana closed 1 year ago

martwana commented 1 year ago

Description of changes:

There was a bug splitting the string on ,

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

groverlalit commented 1 year ago

Thanks for opening the pull request. We observed that the code was not handling white space for Prefix list and custom destinations provided in the CFN parameters. Instead of removing the white space in the environment variables. We are not handling it in the code by removing white space in the string before splitting it into a list. The fix will be shipped in the next release planned by end of Q2.