Improve merging of chained items

aws-solutions / qnabot-on-aws

AWS QnABot is a multi-channel, multi-language conversational interface (chatbot) that responds to your customer's questions, answers, and feedback. The solution allows you to deploy a fully functional chatbot across multiple channels including chat, voice, SMS and Amazon Alexa.

https://aws.amazon.com/solutions/implementations/aws-qnabot

Apache License 2.0

391 stars 251 forks source link

Improve merging of chained items #720

Open amendlik opened 4 months ago

amendlik commented 4 months ago

Issue #, if available: N/A

Description of changes:

Add a space between merged items
Whitespace returned by ResponseBots is no longer required
Enable chaining of plaintext and SSML items while maintaining SSML content
Enable chaining of plaintext and Markdown items while maintaining Markdown content
Honor SSML returned from ResponseBots

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

abhirpat commented 3 months ago

Hi @amendlik do you have export of question you have used for testing these changes ? Have you had a chance to test against provided unit tests and functional test to see if they are passing? If not, please note that we have release 6.0.0 which has additional changes and improvements. Please refer to CHANGELOG for additional details about this release. Thank You!

amendlik commented 3 months ago

I don't see any updates in 6.0.0 that correspond to the improvements provided in this PR.

abhirpat commented 3 months ago

Hi @amendlik could you please provide export of question you have used for testing these changes as requested in previous message? Also, have you had a chance test these changes with unit tests provided ?

amendlik commented 3 months ago

Yes, I will get those to you as soon as I'm able.

abhirpat commented 2 months ago

@amendlik Hope all is well. Please let us know if you had a chance to export the questions you have used for testing these changes as requested in previous message.