search

aws-solutions / video-on-demand-on-aws

An automated reference implementation leveraging AWS Step Functions and AWS Media Services to deploy a scalable fault tolerant Video on demand workflow
https://aws.amazon.com/solutions/video-on-demand-on-aws/
Apache License 2.0
502 stars 240 forks source link

[WIP] CDK conversion #129

Closed amkuchta closed 1 year ago

amkuchta commented 3 years ago

Issue #, if available:

88

Description of changes: This is my initial swag at converting the CloudFormation template to TypeScript-flavored CDK. I'm still running into a few build problems, specifically around the Custom Resources and referencing attributes (e.g. adding MediaPackageVod.EndpointUrl to the Encode Lambda Function variables). It would be nice to have another set of eyes to start looking this over! I've still got a little bit of work to do, but I think it's ready to begin being reviewed.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

amkuchta commented 3 years ago

Partially figured out the issue I was having with the Custom Resource attributes last night, but forgot to push the code before bed - I was passing an array of objects, not an object, as the properties field. Still getting an error, but at least I am closer!

raulmlamzn commented 1 year ago

Thanks for you input. The solution was converted to CDK in v6.