search

aws / Jobs-for-AWS-IoT-embedded-sdk

Client library for using AWS IoT Jobs service on embedded devices
MIT License
13 stars 38 forks source link

Modify Jobs_UpdateMsg to support optional Expected version field #100

Closed priyamourya25 closed 3 months ago

priyamourya25 commented 3 months ago

Please refer the description of expected version for iot jobs: https://docs.aws.amazon.com/iot/latest/apireference/API_iot-jobs-data_UpdateJobExecution.html#API_iot-jobs-data_UpdateJobExecution_RequestSyntax

This is an optional field and the user should be allowed to not pass and still construct a payload without the field. The API forces to provide an optional field here: https://github.com/aws/Jobs-for-AWS-IoT-embedded-sdk/blob/8be356054429da35e9f45dce50404ce1d6b106fe/source/jobs.c#L844

Could you please modify the API so that it allows to append values only if they are passed by the user?

rawalexe commented 3 months ago

Hello Priya, Thank you for pointing this out. Can you please make a PR with the change, we can quickly go over the changes and have it merged.

Best Regards, AR

kstribrnAmzn commented 3 months ago

PR to add this feature - https://github.com/aws/Jobs-for-AWS-IoT-embedded-sdk/pull/104

kstribrnAmzn commented 3 months ago

PR is now merged. Closing