search

aws / Jobs-for-AWS-IoT-embedded-sdk

Client library for using AWS IoT Jobs service on embedded devices
MIT License
12 stars 35 forks source link

Make run script return zero on proof failure #24

Closed karkhaz closed 3 years ago

karkhaz commented 3 years ago

Prior to this commit, litani would return a non-zero code when any proof job failed, and the run script would throw an exception when this happened.

This commit adds the --exit-zero-on-fail flag to the litani run-build invocation, so that litani returns zero even if there are proof failures (but will continue to return a non-zero exit code if there was a crash or some other error).

This is so that CI can distinguish between proof failures (which can be detected in the litani JSON output), and litani crashes due to bugs in litani, inconsistent builds, or other errors.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

karkhaz commented 3 years ago

This PR is now changed to update the litani submodule rather than changing any of the build code in the proofs directory. Updated the title accordingly.