aws / Jobs-for-AWS-IoT-embedded-sdk

Client library for using AWS IoT Jobs service on embedded devices
MIT License
12 stars 35 forks source link

Add Functionality from core_jobs.c #85

Closed bradleysmith23 closed 8 months ago

bradleysmith23 commented 9 months ago

Issue #, if available:

Description of changes: Add APIs from core_jobs.c in https://github.com/FreeRTOS/Labs-Project-ota-example-for-aws-iot-core to jobs.c Add cbmc proofs for functions added from core_jobs.c, reformat cbmc directory Add unit tests for functions added from core_jobs.c

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

bradleysmith23 commented 9 months ago

/bot run formatting

bradleysmith23 commented 9 months ago

/bot run formatting

bradleysmith23 commented 9 months ago

/bot run formatting

bradleysmith23 commented 9 months ago

/bot run formatting

bradleysmith23 commented 9 months ago

/bot run formatting

bradleysmith23 commented 9 months ago

/bot run formatting

bradleysmith23 commented 9 months ago

/bot run formatting

kstribrnAmzn commented 9 months ago

Also - this should be reviewed on the PRBR channel

bradleysmith23 commented 9 months ago

/bot run formatting

bradleysmith23 commented 9 months ago

/bot run formatting

bradleysmith23 commented 9 months ago

/bot run formatting

Skptak commented 8 months ago

So little confused looking through this PR Does this repo have a dependency on coreJSON in order to work? If it does that repository should be added to the .gitmodules file in here and pulled that way If it's only being pulled in for the cbmc tests it should just be cloned down by the run_proofs script and that should be the only mention of it in any of the other files or checks

kstribrnAmzn commented 8 months ago

If it does that repository should be added to the .gitmodules file in here and pulled that way

I could swear we're moving to declaring out dependencies through .gitmodules but actually doing the pull down through CMake that way it always 'just works'.

bradleysmith23 commented 8 months ago

/bot run formatting

bradleysmith23 commented 8 months ago

/bot run formatting