aws / amazon-chime-sdk-android

An Android client library for integrating multi-party communications powered by the Amazon Chime service.
https://aws.amazon.com/chime/chime-sdk/
Apache License 2.0
105 stars 49 forks source link

Fix instruction for building media-no-video-codecs on Maven #601

Closed bjason closed 8 months ago

bjason commented 8 months ago

ℹ️ Description

provide a summary of the changes and the related issue, relevant motivation and context

If builders try to build with media-no-video-codecs following the instruction in README, they will be getting Duplicate class error as classes of amazon-chime-sdk-media were also getting pulled in from amazon-chime-sdk dependency

Issue #, if available

Type of change

🧪 How Has This Been Tested?

describe the tests that you ran to verify your changes, any relevant details for your test configuration

Built with normal media module and no-video-codecs module and verified the demo app and its app size.

implementation 'software.aws.chimesdk:amazon-chime-sdk:0.19.0'
implementation 'software.aws.chimesdk:amazon-chime-sdk-media:0.19.0'
implementation 'software.aws.chimesdk:amazon-chime-sdk-media-no-video-codecs:0.19.0'
implementation ('software.aws.chimesdk:amazon-chime-sdk:0.19.0') {
    exclude module: 'amazon-chime-sdk-media'
}

Unit test coverage

Additional Manual Test

📱 Screenshots, if available

provide screenshots/video record if there's a UI change in demo app

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.