aws / amazon-chime-sdk-android

An Android client library for integrating multi-party communications powered by the Amazon Chime service.
https://aws.amazon.com/chime/chime-sdk/
Apache License 2.0
105 stars 49 forks source link

Fix flaky test #607

Closed linsang21 closed 7 months ago

linsang21 commented 7 months ago

ℹ️ Description

Type of change

🧪 How Has This Been Tested?

tested locally

Unit test coverage

Additional Manual Test

📱 Screenshots, if available

provide screenshots/video record if there's a UI change in demo app

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

georgezy-amzn commented 7 months ago

Let's track this task: Skip BGBlur instrument tests, which requires real device to test (hasn't set up in github action) Also, I can see the changes are more readable, but how does it fix the flaky tests?

linsang21 commented 7 months ago

Let's track this task: Skip BGBlur instrument tests, which requires real device to test (hasn't set up in github action) Also, I can see the changes are more readable, but how does it fix the flaky tests?

Not 100% sure why, I suspect the original nested stream operations has some concurrency issue.