aws / amazon-chime-sdk-component-library-react

Amazon Chime React Component Library with integrations with the Amazon Chime SDK.
Apache License 2.0
267 stars 160 forks source link

The API exposed by Chime SDK Javascript Sample app, and the one exposed by the Chime SDK React Component Sample App differs. #462

Closed ElielCohen closed 3 years ago

ElielCohen commented 3 years ago

Describe the bug The API exposed by Chime SDK Javascript Sample app, and the one exposed by the Chime SDK React Component Sample App differs. This cause an issue with the native SDK implementation, that is built to support only the pure JavaScript API implementation.

To Reproduce Use API served on pure javascript sample meeting app, and on React JS component meeting app. Using Native iOS SDK with API from React JS component will fail, unless you modify the structure expected in JoinMeetingResponse.swift.

Expected behavior Both API should serve the same Response structure.

Structure comparaison : On JS :

You have the following structure :

{ joinInfo: { meeting: { meeting: { [....] (here the externalUserId contains the meeting title) }, }, attendee: { attendee: { [....] }, } }

On ReactJs :

You have the following structure :

{ joinInfo: { title: string (contains the meeting title, that was previously in meeting.meeting.externalUserId). meeting: { [....] (here the externalUserId DOES NOT contain the meeting title, but is set to null) }, attendee: { [....] } }

Additional context In order to support the later, I had to change the file JoinMeetingResponse.swift, so that the structure we use is compatible with the different API response. Without that change, an iOS native application using the Chime SDK won't be able to connect to the API endpoint served by the React Component JS application. Of course this is not a long term solution, and I believe we should align both API to be the same.

Thanks,

Eliel Cohen WebRTC Technological Lead TytoCare

Ps : Have opened defect on amazon-chime-sdk-ios repo as well here : https://github.com/aws/amazon-chime-sdk-ios/issues/264

ElielCohen commented 3 years ago

Ok reason is that the lambda function differs, and that's not per say a bug, so closing it :)