search

aws / amazon-chime-sdk-component-library-react

Amazon Chime React Component Library with integrations with the Amazon Chime SDK.
Apache License 2.0
268 stars 160 forks source link

Bg blur observer #843

Closed michhyun1 closed 1 year ago

michhyun1 commented 1 year ago

Issue #:

Description of changes:

Revert the changes to expose an observer prop on BG Blur provider and BG Replacement provider. Instead, expose the processors that are created in the BG Blur and BG Replacement providers, so that builders may modify the processors, or add observer functions directly to the processors.

Testing

  1. Have you successfully run npm run build:release locally? yes

  2. How did you test these changes?

In the test demo, take the processor from the BG Blur and BG replacement providers, and call addObserver() and removeObserver() on them.

  1. If you made changes to the component library, have you provided corresponding documentation changes?

yes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ltrung commented 1 year ago

Should we update the storybook entries for these two providers to mention that you can use the processors if you need to do more advance use cases https://aws.github.io/amazon-chime-sdk-component-library-react/?path=/docs/sdk-providers-backgroundblurprovider--page

michhyun1 commented 1 year ago

Should we update the storybook entries for these two providers to mention that you can use the processors if you need to do more advance use cases https://aws.github.io/amazon-chime-sdk-component-library-react/?path=/docs/sdk-providers-backgroundblurprovider--page

done