search

aws / amazon-chime-sdk-component-library-react

Amazon Chime React Component Library with integrations with the Amazon Chime SDK.
Apache License 2.0
264 stars 159 forks source link

Add support for node 20 and drop support for node < 18 #935

Closed xuesichao closed 4 months ago

xuesichao commented 4 months ago

Issue #:

923

905

Description of changes: Add support for node 20 and drop support for node < 18

Testing

  1. Have you successfully run npm run build:release locally? Yes

  2. How did you test these changes? Install in meeting demo and verify e2e works.

  3. If you made changes to the component library, have you provided corresponding documentation changes? N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

xuesichao commented 4 months ago

Looks like there are some format only changes, are we using a consistent format across the team?

Yes, we are using Eslint to formate the code. The format changes in this file, I think it's because we haven't touched this file for a long time. Our linting only applies to new files/changes I believe. There're lots of errors and we haven't fixed those so can't use lint to fix all formatting issue at one time.