Description of changes:
Updated LocalAudioOutputProvider to check the value of isAudioOn when hooked on to audioVideo being initialized. It now won't bind the audio if it's already been disabled before startup.
Testing
Have you successfully run npm run build:release locally?
No - it immediately drops out with Didn't find any new commit. Exiting process.
Guessing it's because I've already pushed to my fork? Wasn't mentioned in CONTRIBUTING.md so I didn't attempt to run it until creating the PR. Regular npm run build runs fine though.
How did you test these changes?
Unit tests rerun fine - no tests exist for this component, and not sure how to hook them up given the need to bind audio etc.
Tested locally by installing the dev version into our application. See issue for reproduction steps.
If you made changes to the component library, have you provided corresponding documentation changes?
None made - should continue to operate as documented.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue #964:
Description of changes: Updated LocalAudioOutputProvider to check the value of isAudioOn when hooked on to
audioVideobeing initialized. It now won't bind the audio if it's already been disabled before startup.Testing
npm run build:releaselocally? No - it immediately drops out withDidn't find any new commit. Exiting process.Guessing it's because I've already pushed to my fork? Wasn't mentioned in CONTRIBUTING.md so I didn't attempt to run it until creating the PR. Regular
npm run buildruns fine though.Tested locally by installing the dev version into our application. See issue for reproduction steps.
None made - should continue to operate as documented.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.