aws / amazon-chime-sdk-ios

An iOS client library for integrating multi-party communications powered by the Amazon Chime service.
https://aws.amazon.com/chime/chime-sdk/
Apache License 2.0
144 stars 67 forks source link

Apply meeting constraint on mobile sdk (limit content share resolutio… #605

Closed davidwj123 closed 1 year ago

davidwj123 commented 1 year ago

…n to 1080p)

ℹ️ Description

provide a summary of the changes and the related issue, relevant motivation and context Apply meeting constraint on mobile SDK (limit content share resolution to 1080p -- downscale if necessary)

Issue #, if available

Type of change

🧪 How Has This Been Tested?

describe the tests that you ran to verify your changes, any relevant details for your test configuration

  1. join a meeting from iphone
  2. join the same meeting from chrome browser
  3. iphone starts content share
  4. check chrome://webrtc-internals to make sure content share downstream resolution is not above 1920x1080

Additional Manual Test

📱 Screenshots, if available

provide screenshots/video record if there's a UI change in demo app

✅ Checklist

Integration validation (required before release)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

davidwj123 commented 1 year ago

make code change in another place