aws / amazon-chime-sdk-ios

An iOS client library for integrating multi-party communications powered by the Amazon Chime service.
https://aws.amazon.com/chime/chime-sdk/
Apache License 2.0
139 stars 64 forks source link

Fix audio video config propagation in demo app #636

Closed shi-su closed 5 months ago

shi-su commented 5 months ago

ℹ️ Description

Current demo app logic calls AudioVideoConfiguration(videoMaxResolution) when setting meeting max resolution and this function will override other config selected with default value (i.e., audioMode: stereo48K, callKitEnabled: false, enableAudioRedundancy: true). This change fixes this config propagation issue.

Issue #, if available

Type of change

🧪 How Has This Been Tested?

describe the tests that you ran to verify your changes, any relevant details for your test configuration Smoke tested to verify config is properly propagated.

Additional Manual Test

📱 Screenshots, if available

provide screenshots/video record if there's a UI change in demo app

✅ Checklist

Integration validation (required before release)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

georgezy-amzn commented 5 months ago

Please add the changes to CHANGELOG

shi-su commented 5 months ago

Please add the changes to CHANGELOG

Changed target branch to development and added change to CHANGELOG

georgezy-amzn commented 5 months ago

Thanks for simplifying the codebase!