Revert "Fix content share resume after reconnection (#635)" - Githubissues

aws / amazon-chime-sdk-ios

An iOS client library for integrating multi-party communications powered by the Amazon Chime service.

https://aws.amazon.com/chime/chime-sdk/

Apache License 2.0

139 stars 64 forks source link

Revert "Fix content share resume after reconnection (#635)" #638

Closed linsang21 closed 5 months ago

linsang21 commented 5 months ago

ℹ️ Description

Revert https://github.com/aws/amazon-chime-sdk-ios/pull/635 because of it's side affect - not able to receive didStop callback after calling stopContentShare.

Issue #, if available

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
- [ ] README update
- [ ] CHANGELOG update
- [ ] guides update
[ ] This change requires a dependency update
- [ ] Amazon Chime SDK Media
- [ ] Other (update corresponding legal documents)

🧪 How Has This Been Tested?

describe the tests that you ran to verify your changes, any relevant details for your test configuration

Additional Manual Test

[ ] Pause and resume remote video
[ ] Switch local camera
[ ] Rotate screen back and forth

📱 Screenshots, if available

provide screenshots/video record if there's a UI change in demo app

✅ Checklist

Integration validation (required before release)

[ ] Unit tests pass
[ ] Build SDK against simulator with release options
[ ] Build SDK against device with release options
[ ] Build SDK against simulator with debug options
[ ] Build SDK against device with debug options
[ ] Test Demo against simulator with SDK (debug build) in workspace
[ ] Test Demo against device with SDK (debug build) in workspace
[ ] Test DemoObjC against simulator with SDK (debug build) in workspace
[ ] Test DemoObjC against device with SDK (debug build) in workspace
[ ] Test Demo against simulator with SDK.framework (release build)
[ ] Test Demo against device with SDK.framework (release build)
[ ] Test DemoObjC against simulator with SDK.framework (release build)
[ ] Test DemoObjC against device with SDK.framework (release build)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.