search

aws / amazon-chime-sdk-js

A JavaScript client library for integrating multi-party communications powered by the Amazon Chime service.
Apache License 2.0
713 stars 475 forks source link

Optional chain on the mediaStream in case is null (DefaultContentShareController) #2663

Closed kennyvallejodev closed 1 year ago

kennyvallejodev commented 1 year ago

Issue #2659 and #2535

Description of changes:

Testing: Can these tested using a demo application? Please provide reproducible step-by-step instructions. No

Checklist:

  1. Have you successfully run npm run build:release locally? Yes!

    =============================== Coverage summary ===============================
Statements   : 100% ( 10707/10707 )
Branches     : 100% ( 4719/4719 )
Functions    : 100% ( 2039/2039 )
Lines        : 100% ( 10580/10580 )
================================================================================

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? No

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ltrung commented 1 year ago

@kennyvallejodev Thanks for fixing this. I have created PR #2698 and added unit test case.