search

aws / amazon-chime-sdk-js

A JavaScript client library for integrating multi-party communications powered by the Amazon Chime service.
Apache License 2.0
704 stars 475 forks source link

Add option in demo to join a meeting muted #2702

Closed pracheth closed 1 year ago

pracheth commented 1 year ago

Issue #: NA

Description of changes: Add option in demo to join a meeting muted

Testing: Tested by joining a meeting with and without the Join muted checkbox being selected from additional options. Working as expected

Can these tested using a demo application? Please provide reproducible step-by-step instructions. Yes. Deploy the demo with changes in this PR and join a meeting by either checking the Join muted checkbox or leaving it as is.

Checklist:

  1. Have you successfully run npm run build:release locally? Y

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? No changes to public API definitions.

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ltrung commented 1 year ago

Seem like the npm audit check failed in this CR (not related to your change but will block merge).

xuesichao commented 1 year ago

Seem like the npm audit check failed in this CR (not related to your change but will block merge).

I think it's because of some high risk vulnerabilities, I'll fix them today.

xuesichao commented 1 year ago

I think it's because of some high risk vulnerabilities, I'll fix them today.

GitHub Actions all pass now.