Closed hungns2010 closed 1 year ago
Does all browser support this new metric? Can you link the source? Seem like it only worked in Chrome. Can you update your testing instructions that you have tested in FF and Safari (including mobile).
Does all browser support this new metric? Can you link the source? Seem like it only worked in Chrome. Can you update your testing instructions that you have tested in FF and Safari (including mobile).
Updated the links in the details and will provide the serverless app + instructions for test later.
Issue #: N/A
Description of changes:
audioUpstreamLevel
andaudioDownstreamLevel
to ClientMetricReport.audioUpstreamLevel
will be collected through: https://developer.mozilla.org/en-US/docs/Web/API/RTCAudioSourceStats. This Stats doesn't havessrc
field so we need to collect it throughGlobalMetricReport
.Testing: npm run build:release
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
ClientMetricReport.ts
file. build the serverless demo app: https://7vkcow9r86.execute-api.us-east-1.amazonaws.com/Prod/Checklist:
Have you successfully run
npm run build:release
locally? YesDo you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? No
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.