aws / amazon-chime-sdk-js

A JavaScript client library for integrating multi-party communications powered by the Amazon Chime service.
Apache License 2.0
701 stars 473 forks source link

Do not display a warning message when calling setVideoCodecSendPrefer… #2740

Closed simmkyu closed 1 year ago

simmkyu commented 1 year ago

…ences before start

Issue #:

2734

Description of changes:

Testing:

Can these tested using a demo application? Please provide reproducible step-by-step instructions. Yes.

  1. Navigate to the Chime SDK Serverless Demo.

  2. Enter the meeting title and your name, then click the Continue button.

  3. On the Select devices page, open the browser console.

  4. Run the following script.

    app.audioVideo.setVideoCodecSendPreferences([])
  5. Ensure that the SDK does not produce any warning message like [WARN] SDK - no transition found from NotConnected with Update.

  6. Click the Join button on the Select devices page.

  7. Once you're in the meeting view, open the browser console again.

  8. Run the following script.

    app.audioVideo.setVideoCodecSendPreferences([])
  9. Make sure that the SDK performs the update action by checking for the following log:

    [INFO] SDK - transitioning from Connected to Updating with Update

    Checklist:

  10. Have you successfully run npm run build:release locally? Yes.

  11. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? No, the PR fixes the implementation.

  12. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? No.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.