Description of changes:
This consolidates signaling channel reconnection triggering to MonitorTask, and adds a new status code SignalChannelClosedUnexpectedly to achieve that task. It also fixes reconnection during joins and subscribes, and adds actual bad JOIN message handling instead of the previous, which sorta worked and sorta didn't :).
Testing:
Tested reconnection occurs in the following situations:
On Join (previously would mark this a bad request and not retry)
On first subscribe (previously would mark this a bad request and not retry)
on second subscribe
Mid call, not during subscribe (did not try to reconnect previously)
Also tested that the bad request responses from server in JOIN_ACK were propagated correctly.
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
You can't test these easily besides the mid-call reconnection:
Join a call
switch wifi networks
Connection should immediately reconnect
Checklist:
Have you successfully run npm run build:release locally?
y
Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
n
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
n
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue #: https://github.com/aws/amazon-chime-sdk-js/issues/2568, other internal requests.
Description of changes: This consolidates signaling channel reconnection triggering to
MonitorTask, and adds a new status codeSignalChannelClosedUnexpectedlyto achieve that task. It also fixes reconnection during joins and subscribes, and adds actual bad JOIN message handling instead of the previous, which sorta worked and sorta didn't :).Testing: Tested reconnection occurs in the following situations:
Can these tested using a demo application? Please provide reproducible step-by-step instructions. You can't test these easily besides the mid-call reconnection:
Checklist:
Have you successfully run
npm run build:releaselocally? yDo you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? n
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? n
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.