search

aws / amazon-chime-sdk-js

A JavaScript client library for integrating multi-party communications powered by the Amazon Chime service.
Apache License 2.0
701 stars 473 forks source link

Content constraint revert #2751

Closed davidwj123 closed 11 months ago

davidwj123 commented 11 months ago

Issue #:

Description of changes: Revert resolution constraint for content share

Previous related PR: https://github.com/aws/amazon-chime-sdk-js/pull/2682/files

Testing: Passed:

Can these tested using a demo application? Please provide reproducible step-by-step instructions.

Checklist:

  1. Have you successfully run npm run build:release locally? Yes

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? No

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Yes

davidwj123 commented 11 months ago

We would keep rate control code change and remove the resolution constraint for content share (and the corresponding unit tests).