aws / amazon-chime-sdk-js

A JavaScript client library for integrating multi-party communications powered by the Amazon Chime service.
Apache License 2.0
701 stars 473 forks source link

Fix bug to allow use of Video Simulcast and Redundant Audio Encoding at the same time #2766

Closed dinmin-amzn closed 11 months ago

dinmin-amzn commented 11 months ago

Issue #:

Description of changes: Fix bug to allow use of Video Simulcast and Redundant Audio Encoding at the same time. This was detected by Transcription canary failures and looking deeper, the canaries were failing because they were using Video Simulcast and Redundant Audio Encoding at the same time, which prevent sending and receiving both video and audio and thus caused the Transcription canary to fail since it wasn't receiving audio.

Testing:

Can these tested using a demo application? Please provide reproducible step-by-step instructions.

  1. Have two attendees join a meeting with Video Simulcast and Redundant Audio Encoding both enabled
  2. Verify that both attendees can send and receive audio, video, and content share

Checklist:

  1. Have you successfully run npm run build:release locally? y

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? n

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? n

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.