aws / amazon-chime-sdk-js

A JavaScript client library for integrating multi-party communications powered by the Amazon Chime service.
Apache License 2.0
699 stars 471 forks source link

Revert "Improve reconnection behavior on signaling disconnection (#2744)" #2813

Closed hensmi-amazon closed 7 months ago

hensmi-amazon commented 7 months ago

This reverts commit b29a0cb26d3d774dab6c4c04d6eb3e951e2ea200.

Issue #: https://github.com/aws/amazon-chime-sdk-js/issues/2784

Description of changes: Unfortunately this seemed to be causing issues in certain edge cases along with it's improvements. To mitigate the more noticeable issues I am reverting this for now while I investigate further. Reconnection times will go back to the slower behavior from previous versions for now.

Testing:

Can these tested using a demo application? Please provide reproducible step-by-step instructions.

  1. Join a meeting
  2. Switch wifi off and on, or change networks.
  3. Client should reconnect in around 15 seconds.

Checklist:

  1. Have you successfully run npm run build:release locally? y

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? n

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? n

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.