aws / amazon-chime-sdk-js

A JavaScript client library for integrating multi-party communications powered by the Amazon Chime service.
Apache License 2.0
709 stars 477 forks source link

Fix reconnections when setting audio Attendee Capability to 'None' or 'Send' mid call #2817

Closed hensmi-amazon closed 8 months ago

hensmi-amazon commented 9 months ago

Issue #: None

Description of changes: When setting audio Attendee Capability to 'None' or 'Send' mid call, the backend will cease to send audio RTP packets, leading to reconnections. It will still send RTCPs, so we can use candidate pair stats to keep the connection alive.

Testing: Dynamically set attendee capability for audio to None. No disconnection occurred.

Can these tested using a demo application? Please provide reproducible step-by-step instructions.

  1. Enable dynamic attendee capability control to any attendee.
  2. Set another attendee to audio capability 'None' or 'Send'.
  3. Wait 30 seconds an ensure that attendee does not reconnect.

Checklist:

  1. Have you successfully run npm run build:release locally? y

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? n

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? n

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.