search

aws / amazon-chime-sdk-js

A JavaScript client library for integrating multi-party communications powered by the Amazon Chime service.
Apache License 2.0
709 stars 477 forks source link

Removed 404 link on docs #2824

Closed ByronKweh closed 5 months ago

ByronKweh commented 9 months ago

Removed - High Level Architecture — Building a Meeting Application With the Amazon Chime SDK

From the readme as it is no longer available.

Issue #:

Description of changes:

Testing:

Can these tested using a demo application? Please provide reproducible step-by-step instructions.

Checklist:

  1. Have you successfully run npm run build:release locally?

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ltrung commented 8 months ago

We should figure out if we have another updated doc.

ByronKweh commented 8 months ago

We could use this if we want another high level arch type of doc: https://docs.aws.amazon.com/chime-sdk/latest/dg/service-architecture.html

Alternatively, we could look at this: https://aws.amazon.com/blogs/industries/chime-sdk-for-telemedicine-solution/

Btw, the PR was failing a check on the CI. But it seems like a common issue of the older commits because of some outdated modules. Latest commits seem to be passing fine. Updated the PR to use the latest version of main as the base.

If the PR still fails checks, will make another one with the current head as the base.

Thanks guys!

On Thu, Jan 25, 2024 at 3:20 AM Trung Le @.***> wrote:

We should figure out if we have another updated doc.

— Reply to this email directly, view it on GitHub https://github.com/aws/amazon-chime-sdk-js/pull/2824#issuecomment-1908770363, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQXBQ4OCCHXDZEZ6D6HYGLTYQFNIPAVCNFSM6AAAAABBRCJCXCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBYG43TAMZWGM . You are receiving this because you authored the thread.Message ID: @.***>

ByronKweh commented 5 months ago

Can someone approve the workflow?