search

aws / amazon-chime-sdk-js

A JavaScript client library for integrating multi-party communications powered by the Amazon Chime service.
Apache License 2.0
699 stars 472 forks source link

Add support for node 20 and drop support for node < 18 #2827

Closed xuesichao closed 5 months ago

xuesichao commented 5 months ago

Issue #2825:

Description of changes: Add support for node 20 and drop support for node < 18

Testing:

Verified npm install works for demos and sdks. Tested meeting demo e2e.

Node 18

=============================== Coverage summary ===============================
Statements   : 100% ( 11908/11908 )
Branches     : 100% ( 5399/5399 )
Functions    : 100% ( 2177/2177 )
Lines        : 100% ( 11730/11730 )
================================================================================

~/Projects/amazon-chime-sdk-js node20* 4m 13s                                                   10:50:49 PM
❯ node -v          
v18.17.1

Node 20

=============================== Coverage summary ===============================
Statements   : 100% ( 11908/11908 )
Branches     : 100% ( 5399/5399 )
Functions    : 100% ( 2177/2177 )
Lines        : 100% ( 11730/11730 )
================================================================================

~/Projects/amazon-chime-sdk-js node20* 4m 16s                                                   10:55:43 PM
❯ node -v          
v20.11.0

Can these tested using a demo application? Please provide reproducible step-by-step instructions. N/A

Checklist:

  1. Have you successfully run npm run build:release locally? Yes, succeeded.

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? No

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.