aws / amazon-chime-sdk-js

A JavaScript client library for integrating multi-party communications powered by the Amazon Chime service.
Apache License 2.0
699 stars 472 forks source link

Setup passthrough streams for insertable streams case in the redundan… #2829

Closed dinmin-amzn closed 5 months ago

dinmin-amzn commented 5 months ago

…t audio worker

Issue #: n/a

Description of changes:

This is so that passthrough streams do not get blocked on the main thread. Video streams were being setup as passthrough streams in the main thread, which caused video send and receive to be blocked by long tasks on the main thread. Running the passthrough streams in the redundant audio worker will prevent these blocking issues.

Testing:

Can these tested using a demo application? Please provide reproducible step-by-step instructions.

  1. Join a demo meeting
  2. Verify that the console log [AudioRed] Setting up passthrough transform shows up to indicate that the passthrough transforms for each video are being setup in the redundant audio worker

Checklist:

  1. Have you successfully run npm run build:release locally? yes

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? no

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? no

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.