Description of changes:
TLDR: It probably could be reproduced without content but basically,
The content share peer connection actually subscribes to all remote videos but the backend just marks all sections as inactive (has always been like this).
On the backend, we label the inactive sections with the static label inactive, as some multiple year old mitigation I added for a Firefox Unsignaled SSRC bug.
I'm pushing a fix on the backend to disambiguate the dummy MSIDs in the next week which fully mitigates this issue, but felt like removing the unnecessary subscriptions from the client side as well.
Testing:
Mitigates issue without aforementioned backend fix.
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
Join 2 attendees with video
Enable content share
For unrelated demo fix
Join replica meeting and promote
Enable video
Demote
Demo should automatically turn off video
Checklist:
Have you successfully run npm run build:release locally?
y
Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
n
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
n
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue #: N/A
Description of changes: TLDR: It probably could be reproduced without content but basically,
I'm pushing a fix on the backend to disambiguate the dummy MSIDs in the next week which fully mitigates this issue, but felt like removing the unnecessary subscriptions from the client side as well.
Testing: Mitigates issue without aforementioned backend fix.
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
For unrelated demo fix
Checklist:
Have you successfully run
npm run build:releaselocally? yDo you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? n
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? n
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.