search

aws / amazon-chime-sdk-js

A JavaScript client library for integrating multi-party communications powered by the Amazon Chime service.
Apache License 2.0
699 stars 472 forks source link

Properly wrap 'setSinkId' in try/catch to fix firefox integ. test failures #2852

Closed hensmi-amazon closed 4 months ago

hensmi-amazon commented 4 months ago

Issue #: None

Description of changes: Properly wrap 'setSinkId' in try/catch to fix firefox integ. test failures. This was annoying to debug...

Testing: Forced exception thrown in setDeviceLabelTrigger which leads to the uncaught rejection.

Can these tested using a demo application? Please provide reproducible step-by-step instructions. No

Checklist:

  1. Have you successfully run npm run build:release locally? y

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? n

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? n

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.