aws / amazon-chime-sdk-js

A JavaScript client library for integrating multi-party communications powered by the Amazon Chime service.
Apache License 2.0
699 stars 473 forks source link

Avoid subscribes when simulcast is enabled but not currently sending #2878

Closed hensmi-amazon closed 2 months ago

hensmi-amazon commented 2 months ago

Issue #: None

Description of changes: Noticed this during local testing. Receive only clients would trigger subscribes because the inactive send sections would not include the RTP header extension.

Testing: Tested that a receive only client no longer resubscribes when other videos are turned on.

Can these tested using a demo application? Please provide reproducible step-by-step instructions. No. Nothing noticeable without log diving.

Checklist:

  1. Have you successfully run npm run build:release locally? y

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? n

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? n

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.