search

aws / amazon-chime-sdk-js

A JavaScript client library for integrating multi-party communications powered by the Amazon Chime service.
Apache License 2.0
708 stars 477 forks source link

Delete duplicate code in `demos/browser/server.js` file #2899

Closed dahae0320 closed 3 months ago

dahae0320 commented 4 months ago

Issue #: N/A

Description of changes: Delete duplicate else-if statements in demo app, server.js file. (pathname: end)

Testing:

Can these tested using a demo application? Please provide reproducible step-by-step instructions. No.

Checklist:

  1. Have you successfully run npm run build:release locally? y

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? n

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? n

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

hensmi-amazon commented 4 months ago

unfortunately our integration tests do not work with external forks. I will move it to a remote branch when i get a chance

dahae0320 commented 3 months ago

unfortunately our integration tests do not work with external forks. I will move it to a remote branch when i get a chance

Oh... I'd really appreciate it if you could move it to a remote branch. Thank you so much your comment!

hensmi-amazon commented 3 months ago

Opened https://github.com/aws/amazon-chime-sdk-js/pull/2903 because github doesn't seem to allow me to change the remote branch here.

dahae0320 commented 3 months ago

Thanks :)