search

aws / amazon-chime-sdk-js

A JavaScript client library for integrating multi-party communications powered by the Amazon Chime service.
Apache License 2.0
699 stars 473 forks source link

Update StatsCollector.ts doc string #2905

Closed hensmi-amazon closed 3 weeks ago

hensmi-amazon commented 3 weeks ago

Issue #: N/A

Description of changes: lol

Is it dangerous that builders may know the internal name of our media backend? I'm not sure, but I'm not taking any risks here. Redaction relies on developers to be unaware of git.

Testing:

Can these tested using a demo application? Please provide reproducible step-by-step instructions. Lol

Checklist:

  1. Have you successfully run npm run build:release locally? no, made change in github gui wish me luck

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? n

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? n

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

hensmi-amazon commented 3 weeks ago

gosh, i have to make a changelog edit for that?? will just make it next time i have a change