Description of changes: Just was testing something else and ran across this. The remote video update logic can happen during subscribe (which is mostly fine) and caused issues to the mappings used in the track mapping.
Additionally, the currently location of subscribeFrameSent can cause discrepancies to the track mapping to transceiver. This doesn't cause issues to all highest policy because it will resubscribe anyways, but with SSNA we do not resubscribe in this case.
Testing:
See steps below
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
Enable simulcast and SSNA and join 2 attendees and enable video
Join a third attendee with SSNA. Depending on timing this can be anywhere from a 0-50% repro (my RTT is pretty low).
Checklist:
Have you successfully run npm run build:release locally?
y
Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
n
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
n
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue #: N/A
Description of changes: Just was testing something else and ran across this. The remote video update logic can happen during subscribe (which is mostly fine) and caused issues to the mappings used in the track mapping.
Additionally, the currently location of
subscribeFrameSentcan cause discrepancies to the track mapping to transceiver. This doesn't cause issues to all highest policy because it will resubscribe anyways, but with SSNA we do not resubscribe in this case.Testing: See steps below Can these tested using a demo application? Please provide reproducible step-by-step instructions.
Checklist:
Have you successfully run
npm run build:releaselocally? yDo you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? n
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? n
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.