search

aws / amazon-chime-sdk-js

A JavaScript client library for integrating multi-party communications powered by the Amazon Chime service.
Apache License 2.0
699 stars 473 forks source link

Change getDisplayMedia audio params to exclude noiseSuppression, echo… #2910

Closed michhyun1 closed 2 weeks ago

michhyun1 commented 2 weeks ago

Issue #: Customer issue with sharing browser tab audio and loud video.

Description of changes:

Based on the article: https://medium.com/@trystonperry/why-is-getdisplaymedias-audio-quality-so-bad-b49ba9cfaa83

We don't need these parameters for content sharing. Removing them as they cause unnecessary audio processing.

Testing:

Tested on a serverless demo.

Can these tested using a demo application? Please provide reproducible step-by-step instructions.

Checklist:

  1. Have you successfully run npm run build:release locally?

yes

  1. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?

  2. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.