search

aws / amazon-chime-sdk-js

A JavaScript client library for integrating multi-party communications powered by the Amazon Chime service.
Apache License 2.0
699 stars 473 forks source link

Make redundant audio worker code generation script also work on Windows #2913

Closed dinmin-amzn closed 1 week ago

dinmin-amzn commented 1 week ago

Issue #: https://github.com/aws/amazon-chime-sdk-js/issues/2779

Description of changes:

  1. Use a common tsc path
  2. Handle carriage returns in code string

Testing:

  1. Successfully built on Windows 10 using npm run build
  2. Successfully built on Mac using npm run build:release with all tests passing

Checklist:

  1. Have you successfully run npm run build:release locally? y

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? n

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? n

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.