aws / amazon-chime-sdk-js

A JavaScript client library for integrating multi-party communications powered by the Amazon Chime service.
Apache License 2.0
699 stars 471 forks source link

Do not try to manually adjust SVC layers based off target resolution #2920

Closed hensmi-amazon closed 1 week ago

hensmi-amazon commented 1 week ago

Issue #: None

Description of changes: Do not try to manually adjust SVC layers based off target resolution, as this may lead to an unnecessarily high minimum bitrate to subscribe to all remote videos. Instead rely on browser logic which drops any layers below around 135p.

Testing: Verified SVC still worked and doesn't adjust layers from resolution. Can these tested using a demo application? Please provide reproducible step-by-step instructions. Not really

Checklist:

  1. Have you successfully run npm run build:release locally? y

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? n

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? n

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.