aws / amazon-chime-sdk-js

A JavaScript client library for integrating multi-party communications powered by the Amazon Chime service.
Apache License 2.0
716 stars 472 forks source link

Update uplink policy at codec degradation triggered by encoding health monitor #2942

Closed shi-su closed 2 months ago

shi-su commented 2 months ago

Issue #:

Description of changes: Update uplink policy at codec degradation triggered by encoding health monitor. Error messages like InvalidModificationError: Failed to execute 'setParameters' on 'RTCRtpSender': Attempted to set RtpParameters scalabilityMode to an unsupported value for the current codecs. will emit when degrading codec with SVC enabled.

Testing: Smoke tested to verify the aforementioned error message is not emitted at codec degradation triggered by high encode CPU.

Can these tested using a demo application? Please provide reproducible step-by-step instructions. no

Checklist:

  1. Have you successfully run npm run build:release locally? yes

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? no

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? no

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.