aws / amazon-chime-sdk-js

A JavaScript client library for integrating multi-party communications powered by the Amazon Chime service.
Apache License 2.0
716 stars 472 forks source link

Include STUN packets in received packet reconnection check to mitigate edge cases when all attendee capabilities are None #2958

Closed hensmi-amazon closed 1 month ago

hensmi-amazon commented 1 month ago

Issue #: N/A

Description of changes: I'm not sure why we aren't sending receiver reports if audio/video attendee capability are None but it doesn't really matter too much. I just made this check more resilient by also checking stun packets, which should be sent every 5 seconds as well.

Testing:

Can these tested using a demo application? Please provide reproducible step-by-step instructions.

  1. Send audio/video attendee capabilities to None
  2. Join meeting and ensure you are not disconnected after 15 seconds.

Checklist:

  1. Have you successfully run npm run build:release locally? y

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? n

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? n

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.