aws / amazon-chime-sdk-js

A JavaScript client library for integrating multi-party communications powered by the Amazon Chime service.
Apache License 2.0
717 stars 472 forks source link

User-defined DataMessage callback errors should not be fatal #2974

Closed schontz closed 3 weeks ago

schontz commented 3 weeks ago

What happened and what did you expect to happen?

  1. subscribeToTranscriptEvent callback received unexpected data and threw an error
  2. Actual: The meeting died (fatal error)
  3. Expected: The meeting does not die

Have you reviewed our existing documentation?

Reproduction steps

Something like this:

subscribeToTranscriptEvent(() => {
  throw new Error('bad callback');
});

Amazon Chime SDK for JavaScript version

main

What browsers are you seeing the problem on?

Chome

Browser version

lateset

Meeting and Attendee ID Information.

No response

Browser console logs

Nothing is logged to the console, because the error is swallowed up. It does exist in the logger because fatal errors are logged there.

ltrung commented 3 weeks ago

I think it is expected that realtimeAPI throw fatal error though

ltrung commented 3 weeks ago

Closing as the PR has been merged.