aws / amazon-chime-sdk-js

A JavaScript client library for integrating multi-party communications powered by the Amazon Chime service.
Apache License 2.0
717 stars 472 forks source link

Prevent dataMessage callback errors from killing a meeting #2975

Closed schontz closed 3 weeks ago

schontz commented 3 weeks ago

Issue #: #2974

Description of changes:

Do not create a fatal error when the user-defined callbacks throw an error.

Testing:

Unit tested. POC tested in internal application.

Checklist:

  1. Have you successfully run npm run build:release locally? Yes

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? No

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Yes

hensmi-amazon commented 3 weeks ago

Moved to https://github.com/aws/amazon-chime-sdk-js/pull/2976