aws / amazon-cloudwatch-agent

CloudWatch Agent enables you to collect and export host-level metrics and logs on instances running Linux or Windows server.
MIT License
436 stars 197 forks source link

Add JMX to Windows configuration unit test #1195

Closed jefchien closed 1 month ago

jefchien commented 4 months ago

Description of the issue

Missing translation tests for JMX on Windows.

Description of changes

Adds a JMX section to the complete_windows_config.json and verifies that the translation is valid.

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Updates the unit test.

Requirements

Before commit the code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint
codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.81%. Comparing base (96d4763) to head (532b942). Report is 565 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1195 +/- ## ========================================== + Coverage 57.58% 64.81% +7.22% ========================================== Files 370 460 +90 Lines 17548 22675 +5127 ========================================== + Hits 10105 14696 +4591 - Misses 6848 7281 +433 - Partials 595 698 +103 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 months ago

This PR was marked stale due to lack of activity.

github-actions[bot] commented 3 months ago

This PR was marked stale due to lack of activity.