search

aws / amazon-cloudwatch-agent

CloudWatch Agent enables you to collect and export host-level metrics and logs on instances running Linux or Windows server.
MIT License
444 stars 203 forks source link

[Pending discussion] Fail translate if "System", "Memory", "TCPv4", "TCPv6" has resources defined. #232

Open sethAmazon opened 3 years ago

sethAmazon commented 3 years ago

Current windows metrics behavior : 1.If no resource field specified, apply "------" to comply with windows_perf_counters

  1. However, for objectName ["System", "Memory", "TCPv4", "TCPv6"], we override resources field with "------" no matter what they specified.

Desired behavior proposed: 1.If no resource field specified, apply "------" to comply with windows_perf_counters

  1. Let translator emit log notify customer what objectName is configured with "no instance" option "-----" is not a user friendly log). Translator will also fail translation if any resources field provided for ["System", "Memory", "TCPv4", "TCPv6"].

Pros:

Consistent behavior for all windows metrics. if customer using ["System", "Memory", "TCPv4", "TCPv6" ], and specify instance using "*" or something else, we don't want eliminate their metric silently There is no customer impact right now. We can treat this as low priority.

https://github.com/aws/amazon-cloudwatch-agent/blob/master/translator/translate/metrics/config/registered_instances.go#L12

github-actions[bot] commented 3 years ago

This issue was marked stale due to lack of activity.