search

aws / amazon-cloudwatch-logs-for-fluent-bit

A Fluent Bit output plugin for CloudWatch Logs
Apache License 2.0
170 stars 49 forks source link

Publish built binaries as tagged releases #28

Open karlskewes opened 4 years ago

karlskewes commented 4 years ago

Thank you for this.

We currently mirror this repository so we can build the plug-in for use in ec2 instances without docker. For EKS we use the AWS provided docker image.

Would it be possible to do GitHub release of binaries along with the existing docker images? If there is a public release process that is amenable to a PR am happy to do so.

PettitWesley commented 4 years ago

@kskewes As shown here, our current recommendation is to pull the shared object file out of the image, then upload it somewhere (like S3) and pull it down on all your EC2 instances.

https://github.com/aws/aws-for-fluent-bit/tree/master/examples/fluent-bit/systems-manager-ec2

Let me know what you think of that approach.

karlskewes commented 4 years ago

Thanks very much. Will ponder moving to docker image source versus building off mirrored repo. The recently published release strategy is helpful too. If git tags (2.x.y+) will be added on release that makes our existing setup nicer.

PettitWesley commented 4 years ago

@kskewes Awesome- curious what you think of the SSM approach to installing and running on EC2 as well.

If git tags (2.x.y+) will be added on release that makes our existing setup nicer.

$ git fetch origin && git tag
v2.0.0

As part of the new versioning scheme, all future releases will have git tags.

karlskewes commented 4 years ago

Nice. We don't use SSM at the moment so I'd rather extend our existing tooling. I still think publishing binaries and md5 to GitHub would be useful but respect wish to publish single artifact (docker image).

PettitWesley commented 4 years ago

I'm going to re-open this issue.

Please +1 if you have the same request.

We could set up an AWS CodePipeline to trigger on pushes to master, build the binary, and create a release and attach the binary. If we get enough feedback, we'll prioritize it. But at the moment the AWS for Fluent Bit image is our main focus.