search

aws / amazon-ecs-ami

Packer recipes for building the official ECS-optimized Amazon Linux AMIs
https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs-optimized_AMI.html
Apache License 2.0
204 stars 47 forks source link

pin the aws-neuronx-dkms package version to 2.17.17.0 #314

Closed Yiyuanzzz closed 2 months ago

Yiyuanzzz commented 2 months ago

Summary

This pr pin the aws-neuronx-dkms package version to 2.17.17.0(the aws-neuron-dkms version from the last INF AMI we released) since the aws-neuronx-dkms.noarch 0:2.18.12.0-dkms package was not successfully installed during AMI build process in AMI release 20240919

Implementation details

Testing

Build a test inf ami ami-048bffbac7cedb521 and performed internal testing specific to Inferenetia functionality



<!--
Note for external contributors:
`make test` and `make run-integ-tests` can run in a Linux development
environment like your laptop.  `go test -timeout=30s ./agent/...` and
`.\scripts\run-integ.tests.ps1` can run in a Windows development environment
like your laptop.  Please ensure unit and integration tests pass (on at least
one platform) before opening the pull request.
Once you open the pull request, there will be 14 automatic test checks on the bottom
of the pull request, please make sure they all pass before you merge it. You can
use `bot/test` label to rerun the automatic tests multiple times.
-->

New tests cover the changes: <!-- yes|no -->

### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog.
You can see our changelog entry style here:
https://github.com/aws/amazon-ecs-agent/commit/c9aefebc2b3007f09468f651f6308136bd7b384f
-->

### Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
danehlim commented 2 months ago

Pull request description has some internal jargon which may not be very meaningful outside of ECS Agent team. Can we update the description to be more general (i.e., simply say that we performed internal testing specific to Inferenetia functionality)?