aws / amazon-ecs-cli

The Amazon ECS CLI enables users to run their applications on ECS/Fargate using the Docker Compose file format, quickly provision resources, push/pull images in ECR, and monitor running applications on ECS/Fargate.
https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ECS_CLI.html
Other
1.78k stars 303 forks source link

Create Listener Rule on ELB #268

Open marcato15 opened 7 years ago

marcato15 commented 7 years ago

Looking to use this library for our stack. One of the ways we'd like to use it is to automatically map a hostname {branchName}.branch.example.com. I know golang and not afraid to submit a pull request, but wanted to check if the idea of creating a listener rule to map a hostname to a specific target group was within the goal of this project. If so I'll build it out and submit a pull request.

yinshiua commented 7 years ago

Currently, ECS CLI only support Create Service with existing ALB or ELB, I am not sure if it makes sense for the ECS CLI to create the Listener rules when we don't even create the Target Groups for you.

We are planning to add create ALB and ELB functionality in Create service, then it will make more sense to create the Listeners and the Target Groups with the ecs-cli compose service up command.

If this is a blocker, you can Create Listener rules with the AWS Console or the AWS CLI today. See documentation for more details.

gbvanrenswoude commented 5 years ago

Maybe functionality akin to the AWS ALB ingress controller for Kubernetes would be helpful. Either creation of a Loadbalancer, or creation of a ListenerRule and Targetgroup on an existing ALB would expand the current functionality of the ecs-cli in a meaningful way imho.