search

aws / amazon-ecs-cli

The Amazon ECS CLI enables users to run their applications on ECS/Fargate using the Docker Compose file format, quickly provision resources, push/pull images in ECR, and monitor running applications on ECS/Fargate.
https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ECS_CLI.html
Other
1.75k stars 302 forks source link

Mockgen Dep Complex #479

Closed dickmao closed 6 years ago

dickmao commented 6 years ago

Summary

make generate in dev branch is not idempotent. Results in mockgen failures.

Description

Please consider vendoring mockgen and also removing mockgen generated files from git.

478

SoManyHs commented 6 years ago

Hi @dickmao, We realize there are some small idempotency issues with make generate, but these are usually remedied by running the command again.

The recommendation from the Go team is to commit generated files: ""Also, if the containing package is intended for import by go get, once the file is generated (and tested!) it must be checked into the source code repository to be available to clients." Since the mocks generated by make generate are necessary to run the tests, we also believe we should keep these files in git.

If you have specific failures that are continuing to be a problem, feel free to open a new issue that includes the failure output. Thank you!