search

aws / amazon-ecs-cli

The Amazon ECS CLI enables users to run their applications on ECS/Fargate using the Docker Compose file format, quickly provision resources, push/pull images in ECR, and monitor running applications on ECS/Fargate.
https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ECS_CLI.html
Other
1.77k stars 302 forks source link

Expecting error when appending filepath/arn with no flag (-f/-r) #850

Open iamhopaul123 opened 5 years ago

iamhopaul123 commented 5 years ago

Now

If default docker compose file exists:

$ ecs-cli local up chicken_5.json

INFO[0000] The network ecs-local-network already exists 
INFO[0000] The amazon-ecs-local-container-endpoints container already exists with ID 1129c17e3f5a0ae6756d4461e7d62ddad8bfd67ac891ba2cc3932474219fd60c 
INFO[0000] Started container with ID 1129c17e3f5a0ae6756d4461e7d62ddad8bfd67ac891ba2cc3932474219fd60c 
INFO[0000] Using docker-compose.local.yml to start containers 
Compose out: Found orphan containers (amazon-ecs-cli_wordpress_1, amazon-ecs-cli_mysql_1) for this project. If you removed or renamed this service in your compose file, you can run this command with the --remove-orphans flag to clean it up.
amazon-ecs-cli_web_1 is up-to-date

Expect

It errors out for unexpected arguments.

efekarakus commented 5 years ago

Mmmm, do we think this is a bug? Maybe we can throw an error if the user provided any c.Args()?

iamhopaul123 commented 5 years ago

Mmmm, do we think this is a bug? Maybe we can throw an error if the user provided any c.Args()?

Because at first there is a default .json file using David' task def and I try to run ecs-cli local up chicken_5.json and it gave me errors that completely confused me, which is actually because I don't have the authority to pull David's image. Yeah, maybe I should get rid of the Bug label